Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HB-6642] Update Usage of Getting Screen Scale on iOS17+ #195

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[HB-6642] Update Usage of Getting Screen Scale on iOS17+ #195

merged 1 commit into from
Oct 25, 2023

Conversation

bwised
Copy link
Collaborator

@bwised bwised commented Oct 25, 2023 •
edited
Loading

Title

HB-6642 Replace usage of UIScreen.Main.Scale on native IOS bridge since it is marked deprecated

Description

UIScreen.main is deprecated. Mimic'd the Swift implementation in the iOS native SDK as closely as possible from https://github.com/ChartBoost/ios-helium-sdk/pull/1314.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 620ea53. ± Comparison against base commit 4aff243.

@bwised bwised requested review from a team, kushG, cb-jpadilla and SCastanedaMunoz and removed request for a team October 25, 2023 16:40
cb-jpadilla
cb-jpadilla approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@cb-jpadilla cb-jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment. But lgtm otherwise.

kushG
kushG approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@kushG kushG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SCastanedaMunoz SCastanedaMunoz changed the title HB-6642: update usage of getting screen scale on iOS17+ [HB-6642] Update Usage of Getting Screen Scale on iOS17+ Oct 25, 2023
@SCastanedaMunoz SCastanedaMunoz merged commit c7c88d3 into develop Oct 25, 2023
3 checks passed
@SCastanedaMunoz SCastanedaMunoz deleted the feature/rg/HB-6642 branch October 25, 2023 17:30
@SCastanedaMunoz SCastanedaMunoz added the bugfix Something has been fixed label Oct 25, 2023
@SCastanedaMunoz SCastanedaMunoz added this to the 4.7.0 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SCastanedaMunoz SCastanedaMunoz SCastanedaMunoz approved these changes

@cb-jpadilla cb-jpadilla cb-jpadilla approved these changes

@kushG kushG kushG approved these changes

Assignees

@bwised bwised

Labels
bugfix Something has been fixed
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bwised @kushG @cb-jpadilla @SCastanedaMunoz